[Lldb-commits] [lldb] [LLDB] Make sure FILE* is valid before trying to flush it. (PR #169088)
John Harrison via lldb-commits
lldb-commits at lists.llvm.org
Fri Nov 21 13:39:37 PST 2025
================
@@ -378,7 +378,10 @@ Status NativeFile::Close() {
m_options & (File::eOpenOptionReadOnly | File::eOpenOptionWriteOnly |
File::eOpenOptionReadWrite);
- if (rw == eOpenOptionWriteOnly || rw == eOpenOptionReadWrite) {
+ // If the stream is writable, and has not already been closed, flush
+ // it.
+ if ((rw == eOpenOptionWriteOnly || rw == eOpenOptionReadWrite) &&
+ (m_stream->_flags != m_stream->_fileno)) {
----------------
ashgti wrote:
https://github.com/llvm/llvm-project/pull/169100 I think should clean up the ownership of the FDs to ensure they're only closed a single time.
https://github.com/llvm/llvm-project/pull/169088
More information about the lldb-commits
mailing list