[Lldb-commits] [lldb] [LLDB] Make sure FILE* is valid before trying to flush it. (PR #169088)

[John Harrison via lldb-commits]

================
@@ -378,7 +378,10 @@ Status NativeFile::Close() {
           m_options & (File::eOpenOptionReadOnly | File::eOpenOptionWriteOnly |
                        File::eOpenOptionReadWrite);
 
-      if (rw == eOpenOptionWriteOnly || rw == eOpenOptionReadWrite) {
+      // If the stream is writable, and has not already been closed, flush
+      // it.
+      if ((rw == eOpenOptionWriteOnly || rw == eOpenOptionReadWrite) &&
+          (m_stream->_flags != m_stream->_fileno)) {
----------------
ashgti wrote:

I think if we changed `_el_secondary_file` to a `lldb::FileSP` and use `pty.ReleaseSecondaryFileDescriptor()` to get the fd it should only be closed a single time. This should ensure we only close the file one time, I think.

https://github.com/llvm/llvm-project/pull/169088