[Lldb-commits] [lldb] [LLDB, x86, FreeBSD] Fix Architecture parsing by reading the ELF header. (PR #162811)

[via lldb-commits]

aokblast wrote:

> LGTM, I see that NetBSD and Linux do this too.
> 
> Though I doubt whether debugging works on those platforms either, and I don't think we have upstream tests for it so I won't demand them here.
> 
> This change applies to AArch64 as well, right? At least the code is generic, maybe AArch32 binaries aren't allowed on AArch64 FreeBSD.

This is an interesting question. I think that there are already some aarch64 based chip, like [this](https://en.wikichip.org/wiki/cavium/thunderx2), does not support running arm32 naturally.
I have tried compiling -m32 on our aarch64 based server. And the error shows:
ld: error: /tmp/main-2d8f5f.o is incompatible with /usr/lib/crt1.o
cc: error: linker command failed with exit code 1 (use -v to see invocation).
I suspect that we might see similar error on our rtld since we don't ship 32bit sysroots.
Due to these reasons, I would suggest that LLDB should not do any assuption and just run the binary to see if run time support it. 
> 
> If you do get this working overall, I would like to see tests that run on Linux. If it's not a massive amount of work I can help fix Linux, if it is though, FreeBSD only test case would be fine. I'll take something over nothing.


https://github.com/llvm/llvm-project/pull/162811