[Lldb-commits] [lldb] [LLDB, x86, FreeBSD] Fix Architecture parsing by reading the ELF header. (PR #162811)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett approved this pull request.

LGTM, I see that NetBSD and Linux do this too.

Though I doubt whether debugging works on those platforms either, and I don't think we have upstream tests for it so I won't demand them here.

This change applies to AArch64 as well, right? At least the code is generic, maybe AArch32 binaries aren't allowed on AArch64 FreeBSD.

If you do get this working overall, I would like to see tests that run on Linux. If it's not a massive amount of work I can help fix Linux, if it is though, FreeBSD only test case would be fine. I'll take something over nothing.

https://github.com/llvm/llvm-project/pull/162811