[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

[Igor Kudrin via lldb-commits]

================
@@ -16,7 +16,7 @@ static std::optional<uint32_t>
 getNoteType(const llvm::Triple &Triple,
             llvm::ArrayRef<RegsetDesc> RegsetDescs) {
   for (const auto &Entry : RegsetDescs) {
-    if (Entry.OS != Triple.getOS())
+    if (Entry.OS != llvm::Triple::UnknownOS && Entry.OS != Triple.getOS())
----------------
igorkudrin wrote:

This is to skip comparing the OS type, so `ARM_VFP_Desc[]` can be generalized. Linux and FreeBSD store the VFP registers in the same way. Assuming the CPU is ARM, it is unlikely that another OS would use a note with the same type for something different.

https://github.com/llvm/llvm-project/pull/155956