[Lldb-commits] [lldb] remove a superfluous assignment statement (PR #152669)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: None (sedymrak)

<details>
<summary>Changes</summary>

`cfa_reg_contents` is a local variable. Whatever value we assign there right before the `return` statement will be lost anyway.

---
Full diff: https://github.com/llvm/llvm-project/pull/152669.diff


1 Files Affected:

- (modified) lldb/source/Target/RegisterContextUnwind.cpp (-1) 


``````````diff
diff --git a/lldb/source/Target/RegisterContextUnwind.cpp b/lldb/source/Target/RegisterContextUnwind.cpp
index 9e9e2d86958f3..bcf1297f2114f 100644
--- a/lldb/source/Target/RegisterContextUnwind.cpp
+++ b/lldb/source/Target/RegisterContextUnwind.cpp
@@ -2026,7 +2026,6 @@ bool RegisterContextUnwind::ReadFrameAddress(
             "Got an invalid CFA register value - reg %s (%d), value 0x%" PRIx64,
             cfa_reg.GetName(), cfa_reg.GetAsKind(eRegisterKindLLDB),
             cfa_reg_contents);
-        cfa_reg_contents = LLDB_INVALID_ADDRESS;
         return false;
       }
       address = cfa_reg_contents + fa.GetOffset();

``````````

</details>


https://github.com/llvm/llvm-project/pull/152669