[Lldb-commits] [lldb] remove a superfluous assignment statement (PR #152669)

[via lldb-commits]

https://github.com/sedymrak created https://github.com/llvm/llvm-project/pull/152669

`cfa_reg_contents` is a local variable. Whatever value we assign there right before the `return` statement will be lost anyway.

>From 64f701ce6c94ceab4a411d7ba0d0ca5932b942cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matej=20Ko=C5=A1=C3=ADk?= <matej.kosik at codasip.com>
Date: Fri, 8 Aug 2025 10:49:45 +0200
Subject: [PATCH] remove a superfluous assignment statement

---
 lldb/source/Target/RegisterContextUnwind.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lldb/source/Target/RegisterContextUnwind.cpp b/lldb/source/Target/RegisterContextUnwind.cpp
index 9e9e2d86958f3..bcf1297f2114f 100644
--- a/lldb/source/Target/RegisterContextUnwind.cpp
+++ b/lldb/source/Target/RegisterContextUnwind.cpp
@@ -2026,7 +2026,6 @@ bool RegisterContextUnwind::ReadFrameAddress(
             "Got an invalid CFA register value - reg %s (%d), value 0x%" PRIx64,
             cfa_reg.GetName(), cfa_reg.GetAsKind(eRegisterKindLLDB),
             cfa_reg_contents);
-        cfa_reg_contents = LLDB_INVALID_ADDRESS;
         return false;
       }
       address = cfa_reg_contents + fa.GetOffset();