[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

[John Harrison via lldb-commits]

================
@@ -23,9 +23,10 @@ namespace lldb_dap {
 /// Launch request; value of command field is 'launch'.
 Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const {
   // Validate that we have a well formed launch request.
-  if (!arguments.launchCommands.empty() && arguments.runInTerminal)
+  if (!arguments.launchCommands.empty() &&
+      arguments.console != protocol::eInternalConsole)
     return make_error<DAPError>(
-        "'launchCommands' and 'runInTerminal' are mutually exclusive");
+        "'launchCommands' and 'console' are mutually exclusive");
----------------
ashgti wrote:

How does `"'launchCommands' and non-integrated 'console's are mutually exclusive"`

https://github.com/llvm/llvm-project/pull/146950