[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

[John Harrison via lldb-commits]

================
@@ -528,7 +528,23 @@
               "runInTerminal": {
                 "type": "boolean",
                 "description": "Launch the program inside an integrated terminal in the IDE. Useful for debugging interactive command line programs",
-                "default": false
+                "default": false,
+                "deprecationMessage": "Attribute 'runInTerminal' is deprecated, use 'console' instead."
+              },
+              "console": {
+                "type": "string",
+                "enum": [
+                  "internalConsole",
+                  "integratedTerminal",
+                  "externalTerminal"
+                ],
+                "enumDescriptions": [
+                  "Launch the program inside an integrated terminal in the IDE.",
+                  "Launch the program inside an external terminal window.",
+                  "Use Debug Console for output (input is not supported)."
----------------
ashgti wrote:

I think these are in the wrong order, the last one sounds like `internalConsole`.

https://github.com/llvm/llvm-project/pull/146950