[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 16 07:10:26 PDT 2025


================
@@ -934,6 +943,12 @@ void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level,
     }
     s->IndentLess();
   }
+
+  // Reset the colors back to normal if they were previously greyed out.
+  if (s->AsRawOstream().colors_enabled())
----------------
JDevlieghere wrote:

The comment says "if they were previously greyed out" but you're not actually checking that. I think with the helper variable the code is sufficiently self-explanatory that we can drop the comment. 
```suggestion
  // Reset the colors back to normal if they were previously greyed out.
  if (highlight_disabled)
```

https://github.com/llvm/llvm-project/pull/91404


More information about the lldb-commits mailing list