[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

[Jonas Devlieghere via lldb-commits]

================
@@ -838,6 +840,13 @@ void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level,
                                 bool show_locations) {
   assert(s != nullptr);
 
+  // Grey out any disabled breakpoints in the list of breakpoints.
+  if (!IsEnabled())
+    if (s->AsRawOstream().colors_enabled())
----------------
JDevlieghere wrote:

Nit: The comment says "Grey out" but this is configurable, so I'd say something like highlight. It also says "in the list of breakpoints" but that's (maybe the only way) this function is called.  GetDescription isn't actually printing the list so I don't think that belongs here.  

```suggestion
    const bool highlight_disabled = !IsEnabled() && s->AsRawOstream().colors_enabled();
  if (highlight_disabled)
```

https://github.com/llvm/llvm-project/pull/91404