[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

[Jonas Devlieghere via lldb-commits]

================
@@ -212,6 +212,8 @@ class PluginManager {
   static Status SaveCore(const lldb::ProcessSP &process_sp,
                          lldb_private::SaveCoreOptions &core_options);
 
+  static llvm::SmallVector<llvm::StringRef> GetSaveCorePluginNames();
----------------
JDevlieghere wrote:

It's rather uncommon to return a `SmallVector` by value. Usually, you return a `SmallVectorImpl` by reference (you can't by value because it's a polymorphic type) so that the caller can decide how many elements there are. Given that this isn't actually hot code, I would just return a plain `vector` (rather than giving this an output argument). 

https://github.com/llvm/llvm-project/pull/143126