[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

[Ebuka Ezike via lldb-commits]

================
@@ -797,7 +797,8 @@ let Command = "process save_core" in {
     EnumArg<"SaveCoreStyle">, Desc<"Request a specific style "
     "of corefile to be saved.">;
   def process_save_core_plugin_name : Option<"plugin-name", "p">,
-    OptionalArg<"Plugin">, Desc<"Specify a plugin name to create the core file. "
+    Arg<"Plugin">, Completion<"ProcessSaveCorePlugin">,
----------------
da-viper wrote:

I changed it to that because passing just the `--plugin` argument does not have change the change on how the core is saved.  as it always checks plugins. 

https://github.com/llvm/llvm-project/blob/4e6896244f4129a22e311f7f6290a595b6f03b75/lldb/source/Core/PluginManager.cpp#L825-L843

I reverted it back to optional because of it breaking user space. 

https://github.com/llvm/llvm-project/pull/143126