[Lldb-commits] [lldb] [lldb-dap] fix config value comparison (PR #142017)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Ely Ronnen (eronnen)

<details>
<summary>Changes</summary>

Fix TypeSCript comparison (when defining an empty config string like `commandEscapePrefix=""` it would skip it)

---
Full diff: https://github.com/llvm/llvm-project/pull/142017.diff


1 Files Affected:

- (modified) lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts (+1-1) 


``````````diff
diff --git a/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts b/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
index 957bc5e1eb956..316ffaf47c3d2 100644
--- a/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
+++ b/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
@@ -84,7 +84,7 @@ export class LLDBDapConfigurationProvider
         continue;
       }
       const value = config.get(key);
-      if (!value || value === cfg.default) {
+      if (value === undefined || value === cfg.default) {
         continue;
       }
       switch (cfg.type) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/142017