[Lldb-commits] [lldb] [lldb-dap] fix config value comparison (PR #142017)

Ely Ronnen via lldb-commits lldb-commits at lists.llvm.org
Thu May 29 12:27:52 PDT 2025


https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/142017

Fix TypeSCript comparison (when defining an empty config string like `commandEscapePrefix=""` it would skip it)

>From 8632a15c5fa4a11b1a108d9b763b9241b5a2bc41 Mon Sep 17 00:00:00 2001
From: Ely Ronnen <elyronnen at gmail.com>
Date: Thu, 29 May 2025 21:22:58 +0200
Subject: [PATCH] [lldb-dap] fix config value comparison

---
 lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts b/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
index 957bc5e1eb956..316ffaf47c3d2 100644
--- a/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
+++ b/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
@@ -84,7 +84,7 @@ export class LLDBDapConfigurationProvider
         continue;
       }
       const value = config.get(key);
-      if (!value || value === cfg.default) {
+      if (value === undefined || value === cfg.default) {
         continue;
       }
       switch (cfg.type) {



More information about the lldb-commits mailing list