[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 25 12:25:41 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Ely Ronnen (eronnen)

<details>
<summary>Changes</summary>

* Fix broken tests that use commanEscapePrefix="",  in my case `TestDAP_stackTraceMissingModule.test_missingModule`

---
Full diff: https://github.com/llvm/llvm-project/pull/137384.diff


1 Files Affected:

- (modified) lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py (+1-1) 


``````````diff
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
index 0f8a84461c9e7..40bdcf99e5b09 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
@@ -860,7 +860,7 @@ def request_launch(
         args_dict["enableAutoVariableSummaries"] = enableAutoVariableSummaries
         args_dict["enableSyntheticChildDebugging"] = enableSyntheticChildDebugging
         args_dict["displayExtendedBacktrace"] = displayExtendedBacktrace
-        if commandEscapePrefix:
+        if commandEscapePrefix is not None:
             args_dict["commandEscapePrefix"] = commandEscapePrefix
         command_dict = {"command": "launch", "type": "request", "arguments": args_dict}
         response = self.send_recv(command_dict)

``````````

</details>


https://github.com/llvm/llvm-project/pull/137384


More information about the lldb-commits mailing list