[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

Ely Ronnen via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 25 12:25:05 PDT 2025


https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/137384

* Fix broken tests that use commanEscapePrefix="",  in my case `TestDAP_stackTraceMissingModule.test_missingModule`

>From c496d0ec97db4a1bcb4717afb7427648e0c371ec Mon Sep 17 00:00:00 2001
From: Ely Ronnen <elyronnen at gmail.com>
Date: Fri, 25 Apr 2025 21:23:19 +0200
Subject: [PATCH] [lldb-dap] fix broken tests with commanEscapePrefix=""

---
 .../packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
index 0f8a84461c9e7..40bdcf99e5b09 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
@@ -860,7 +860,7 @@ def request_launch(
         args_dict["enableAutoVariableSummaries"] = enableAutoVariableSummaries
         args_dict["enableSyntheticChildDebugging"] = enableSyntheticChildDebugging
         args_dict["displayExtendedBacktrace"] = displayExtendedBacktrace
-        if commandEscapePrefix:
+        if commandEscapePrefix is not None:
             args_dict["commandEscapePrefix"] = commandEscapePrefix
         command_dict = {"command": "launch", "type": "request", "arguments": args_dict}
         response = self.send_recv(command_dict)



More information about the lldb-commits mailing list