[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

[Michael Buch via lldb-commits]

================
@@ -163,11 +163,24 @@ lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() {
   return lldb::ChildCacheState::eRefetch;
 }
 
-size_t lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::
+llvm::Expected<size_t>
+lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::
     GetIndexOfChildWithName(ConstString name) {
   if (!m_start || !m_finish)
-    return UINT32_MAX;
-  return ExtractIndexFromString(name.GetCString());
+    return llvm::createStringError(
+        "'SyntheticChildrenFrontEnd::LibcxxStdVectorSyntheticFrontEnd' cannot "
+        "find index of child '%s'. (m_start='" PRIu32 "', m_finish='" PRIu32
+        "')",
+        name.AsCString(), m_start, m_finish);
----------------
Michael137 wrote:

```suggestion
        "find index of child '%s'. (m_start='%p', m_finish='%p')",
        name.AsCString(), m_start, m_finish);
```

https://github.com/llvm/llvm-project/pull/136693