[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

[Michael Buch via lldb-commits]

================
@@ -123,11 +123,22 @@ lldb_private::formatters::LibcxxStdValarraySyntheticFrontEnd::Update() {
   return ChildCacheState::eRefetch;
 }
 
-size_t lldb_private::formatters::LibcxxStdValarraySyntheticFrontEnd::
+llvm::Expected<size_t>
+lldb_private::formatters::LibcxxStdValarraySyntheticFrontEnd::
     GetIndexOfChildWithName(ConstString name) {
   if (!m_start || !m_finish)
-    return std::numeric_limits<size_t>::max();
-  return ExtractIndexFromString(name.GetCString());
+    return llvm::createStringError(
+        "'SyntheticChildrenFrontEnd::LibcxxStdValarraySyntheticFrontEnd' "
+        "cannot find index of child '%s'. (m_start='" PRIu32
+        "', m_finish='" PRIu32 "')",
----------------
Michael137 wrote:

```suggestion
        "cannot find index of child '%s'. (m_start='%p', m_finish='%p')",
```

https://github.com/llvm/llvm-project/pull/136693