[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)
Hu Jialun via lldb-commits
lldb-commits at lists.llvm.org
Fri Jan 24 18:36:58 PST 2025
SuibianP wrote:
I [enabled `runInTerminal` tests for Windows](https://github.com/llvm/llvm-project/pull/121269/files#diff-38cf10e0a83515e5c6acf5449a3f5de1d63f116d932a32ba169b746826ead1d4) (will fix line 93 later) except for the 4 launcher tests that requires `os.mkfifo` (https://github.com/python/cpython/issues/103510) and they pass on my local computer. This should be sufficient to guarantee the common functionalities. I can do a simple polyfill using `pywin32` for Windows if the ignored test is a blocker for this PR.
All LLDB tests still pass on Linux CI, so there seems to be no regression https://buildkite.com/llvm-project/github-pull-requests/builds/140240
https://github.com/llvm/llvm-project/pull/121269
More information about the lldb-commits
mailing list