[Lldb-commits] [lldb] aeffc01 - [lldb][DWARFASTParserClang][NFC] Remove redundant local variable

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 21 06:34:15 PST 2025


Author: Michael Buch
Date: 2025-01-21T14:33:37Z
New Revision: aeffc01a7247cd95560b0c35b7a2c8d5a434b1f0

URL: https://github.com/llvm/llvm-project/commit/aeffc01a7247cd95560b0c35b7a2c8d5a434b1f0
DIFF: https://github.com/llvm/llvm-project/commit/aeffc01a7247cd95560b0c35b7a2c8d5a434b1f0.diff

LOG: [lldb][DWARFASTParserClang][NFC] Remove redundant local variable

Tiny improvement to reviewability of an upcoming refactor.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index fb3af44abfa8d4..68fa1d13943a16 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -3127,7 +3127,6 @@ size_t DWARFASTParserClang::ParseChildParameters(
         }
       }
 
-      bool skip = false;
       if (is_artificial) {
         // In order to determine if a C++ member function is "const" we
         // have to look at the const-ness of "this"...
@@ -3150,10 +3149,7 @@ size_t DWARFASTParserClang::ParseChildParameters(
             }
           }
         }
-        skip = true;
-      }
-
-      if (!skip) {
+      } else {
         Type *type = die.ResolveTypeUID(param_type_die_form.Reference());
         if (type) {
           function_param_types.push_back(type->GetForwardCompilerType());


        


More information about the lldb-commits mailing list