[Lldb-commits] [lldb] [lldb] Use the terminal height for paging editline completions (PR #119914)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 16 08:30:16 PST 2024


================
@@ -1000,14 +1010,17 @@ PrintCompletion(FILE *output_file,
       if (position + description_length < max_length) {
         fprintf(output_file, "%.*s\n", static_cast<int>(description_length),
                 line.data());
+        lines_printed++;
----------------
JDevlieghere wrote:

Ah good point. I considered the situation where we would potentially exceed the page size if the last entry was a multiline one (and deemed that acceptable) but I didn't account for it in the check. We can make that a `>=`. 

https://github.com/llvm/llvm-project/pull/119914


More information about the lldb-commits mailing list