[Lldb-commits] [lldb] [lldb] Use the terminal height for paging editline completions (PR #119914)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 16 04:38:31 PST 2024


================
@@ -1000,14 +1010,17 @@ PrintCompletion(FILE *output_file,
       if (position + description_length < max_length) {
         fprintf(output_file, "%.*s\n", static_cast<int>(description_length),
                 line.data());
+        lines_printed++;
----------------
labath wrote:

It seems like this could be a problem if we cross the page boundary in the middle of a multi-line description. The worst part is that given that the code above checks for strict equality, this situation might end up cause us to dump everything in a single go.

https://github.com/llvm/llvm-project/pull/119914


More information about the lldb-commits mailing list