[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

[John Harrison via lldb-commits]

================
@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types";
 export class LLDBDapDescriptorFactory
   implements vscode.DebugAdapterDescriptorFactory
 {
-  private lldbDapOptions: LLDBDapOptions;
-
-  constructor(lldbDapOptions: LLDBDapOptions) {
-    this.lldbDapOptions = lldbDapOptions;
-  }
-
-  static async isValidDebugAdapterPath(
-    pathUri: vscode.Uri,
-  ): Promise<Boolean> {
+  static async isValidFile(pathUri: vscode.Uri): Promise<Boolean> {
----------------
ashgti wrote:

I don't think this is doing anything specific for `LLDBDapDescriptorFactory` and a top level `isValidExe` or `isExecutable` is straight forward to reason vs `LLDBDapDescriptorFactory.isValidFile`.

https://github.com/llvm/llvm-project/pull/118547