[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

[Jonas Devlieghere via lldb-commits]

================
@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types";
 export class LLDBDapDescriptorFactory
   implements vscode.DebugAdapterDescriptorFactory
 {
-  private lldbDapOptions: LLDBDapOptions;
-
-  constructor(lldbDapOptions: LLDBDapOptions) {
-    this.lldbDapOptions = lldbDapOptions;
-  }
-
-  static async isValidDebugAdapterPath(
-    pathUri: vscode.Uri,
-  ): Promise<Boolean> {
+  static async isValidFile(pathUri: vscode.Uri): Promise<Boolean> {
----------------
JDevlieghere wrote:

We're also calling this from `extension.ts`. I guess we could export the function but that doesn't seem much better than leaving it a static method?

https://github.com/llvm/llvm-project/pull/118547