[Lldb-commits] [lldb] [lldb] Remove SymbolFilePDB and make the native one the default (PR #113647)

[Martin Storsjö via lldb-commits]

mstorsjo wrote:

> Interesting. Based on a conversation at the dev meeting, I was under the impression that the DIA-based implementation was in worse shape and the native one in better shape. I also have a memory of bug reports about PDB parsing where originators were asked to check with `LLDB_USE_NATIVE_PDB_READER` instead.

I don't really know it too closely either, but my understanding was that the DIA SDK based one was more complete. Both probably have their own sets of bugs anyway, so "check with the other implementation" always is a reasonable assumption.

I also agree that getting rid of the DIA SDK based one would be the way to go - that also gets us equal functionality across all platforms.

In any case - using the DIA SDK is the canonical configuration where tests do pass AFAIK; bringing configurations without it up to the same level would at least be a first step towards resolving this.

https://github.com/llvm/llvm-project/pull/113647