[Lldb-commits] [lldb] [lldb] Remove SymbolFilePDB and make the native one the default (PR #113647)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

Interesting. Based on a conversation at the dev meeting, I was under the impression that the DIA-based implementation was in worse shape and the native one in better shape. I also have a memory of bug reports about PDB parsing where originators were asked to check with `LLDB_USE_NATIVE_PDB_READER` instead. 

FWIW I don't have a vested interest in removing this code. This came up in a conversation about understanding what works and doesn't work on Windows. I feel like we're in limbo here and I'd love to get to a point where we can set clear expectations to our users about what does and doesn't work. Having multiple configurations of things (like the symbol file an the process plugin) doesn't make that matrix easier to understand. 

> What axis do we have here?
> 
> * Native or non-native?
> * DIA SDK or not?


My understanding of the situation is that `SymbolFilePDB` uses the Microsoft Debug Interface Access (DIA) SDK, which of course is only available on Windows and that `SymbolFileNativePDB` uses LLVM's "native" PDB parser, which should be available on all platforms (similar to how you can parse DWARF on Windows). In other words, if you're on Windows, you can use both. If you're on another platform, you can only use the latter.  

https://github.com/llvm/llvm-project/pull/113647