[Lldb-commits] [lldb] [lldb][test] Use llvm-strip instead of strip on non-Darwin platforms for TestSymbolFileJSON (PR #111820)

via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 10 05:06:18 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Vladislav Dzhidzhoev (dzhidzhoev)

<details>
<summary>Changes</summary>

This is to fix buildbot failure https://lab.llvm.org/staging/#/builders/195/builds/4242.

The test can't be used with llvm-strip on macOS. Apparently, llvm-strip/llvm-objcopy can't clean symbols from Mach-O nlists.

---
Full diff: https://github.com/llvm/llvm-project/pull/111820.diff


1 Files Affected:

- (modified) lldb/test/API/functionalities/json/symbol-file/Makefile (+4) 


``````````diff
diff --git a/lldb/test/API/functionalities/json/symbol-file/Makefile b/lldb/test/API/functionalities/json/symbol-file/Makefile
index aff841c364299c..1df4a16fbf4d91 100644
--- a/lldb/test/API/functionalities/json/symbol-file/Makefile
+++ b/lldb/test/API/functionalities/json/symbol-file/Makefile
@@ -3,6 +3,10 @@ C_SOURCES := main.c
 all: stripped.out
 
 stripped.out : a.out
+ifeq "$(OS)" "Darwin"
 	strip a.out -o stripped.out
+else
+	$(STRIP) a.out -o stripped.out
+endif
 
 include Makefile.rules

``````````

</details>


https://github.com/llvm/llvm-project/pull/111820


More information about the lldb-commits mailing list