[Lldb-commits] [lldb] [lldb][test] Use llvm-strip instead of strip on non-Darwin platforms for TestSymbolFileJSON (PR #111820)

[Vladislav Dzhidzhoev via lldb-commits]

https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/111820

This is to fix buildbot failure https://lab.llvm.org/staging/#/builders/195/builds/4242.

The test can't be used with llvm-strip on macOS. Apparently, llvm-strip/llvm-objcopy can't clean symbols from Mach-O nlists.

>From 3f7155ed55d0b34bd8633a0a2d1303fd8757f0f4 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev <vdzhidzhoev at accesssoftek.com>
Date: Thu, 10 Oct 2024 13:54:55 +0200
Subject: [PATCH] [lldb][test] Use llvm-strip instead of strip on non-Darwin
 platforms for TestSymbolFileJSON

This is to fix buildbot failure
https://lab.llvm.org/staging/#/builders/195/builds/4242.

The test can't be used with llvm-strip on macOS. Apparently,
llvm-strip/llvm-objcopy can't clean symbols from mach-O nlists.
---
 lldb/test/API/functionalities/json/symbol-file/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lldb/test/API/functionalities/json/symbol-file/Makefile b/lldb/test/API/functionalities/json/symbol-file/Makefile
index aff841c364299c..1df4a16fbf4d91 100644
--- a/lldb/test/API/functionalities/json/symbol-file/Makefile
+++ b/lldb/test/API/functionalities/json/symbol-file/Makefile
@@ -3,6 +3,10 @@ C_SOURCES := main.c
 all: stripped.out
 
 stripped.out : a.out
+ifeq "$(OS)" "Darwin"
 	strip a.out -o stripped.out
+else
+	$(STRIP) a.out -o stripped.out
+endif
 
 include Makefile.rules