[Lldb-commits] [lldb] ec00999 - [lldb][test] Remove xfails from static lib tests on Windows

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 8 01:59:38 PDT 2024


Author: David Spickett
Date: 2024-10-08T08:58:43Z
New Revision: ec009994a06338995dfb6431c943b299f9327fd2

URL: https://github.com/llvm/llvm-project/commit/ec009994a06338995dfb6431c943b299f9327fd2
DIFF: https://github.com/llvm/llvm-project/commit/ec009994a06338995dfb6431c943b299f9327fd2.diff

LOG: [lldb][test] Remove xfails from static lib tests on Windows

Originally failing due to https://github.com/llvm/llvm-project/issues/24901,
but since https://github.com/llvm/llvm-project/pull/110837 the
test is passing.

Already removed one xfail but didn't realise we had more for
the same bug.

Added: 
    

Modified: 
    lldb/test/API/functionalities/archives/TestBSDArchives.py
    lldb/test/API/macosx/duplicate-archive-members/TestDuplicateMembers.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/archives/TestBSDArchives.py b/lldb/test/API/functionalities/archives/TestBSDArchives.py
index eb79b7ff47ebc7..88acafdd9e22aa 100644
--- a/lldb/test/API/functionalities/archives/TestBSDArchives.py
+++ b/lldb/test/API/functionalities/archives/TestBSDArchives.py
@@ -121,10 +121,6 @@ def test_frame_var_errors_when_archive_missing(self):
 
     @skipIfRemote
     @skipIf(compiler="clang", compiler_version=["<", "12.0"])
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24527.  Makefile.rules doesn't know how to build static libs on Windows",
-    )
     def test_archive_specifications(self):
         """
         Create archives and make sure the information we get when retrieving

diff  --git a/lldb/test/API/macosx/duplicate-archive-members/TestDuplicateMembers.py b/lldb/test/API/macosx/duplicate-archive-members/TestDuplicateMembers.py
index 1746b2d3a47b19..1a0e60e53b1a5b 100644
--- a/lldb/test/API/macosx/duplicate-archive-members/TestDuplicateMembers.py
+++ b/lldb/test/API/macosx/duplicate-archive-members/TestDuplicateMembers.py
@@ -8,10 +8,6 @@
 
 
 class BSDArchivesTestCase(TestBase):
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24527.  Makefile.rules doesn't know how to build static libs on Windows",
-    )
     def test(self):
         """Break inside a() and b() defined within libfoo.a."""
         self.build()


        


More information about the lldb-commits mailing list