[Lldb-commits] [lldb] 7c10876 - [lldb][test] Fix unexpected pass of TestBSDArchives on Windows

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 8 01:56:40 PDT 2024


Author: David Spickett
Date: 2024-10-08T08:56:21Z
New Revision: 7c1087613bb9f4ceebb991e5a4b2ef4d5adb4dfa

URL: https://github.com/llvm/llvm-project/commit/7c1087613bb9f4ceebb991e5a4b2ef4d5adb4dfa
DIFF: https://github.com/llvm/llvm-project/commit/7c1087613bb9f4ceebb991e5a4b2ef4d5adb4dfa.diff

LOG: [lldb][test] Fix unexpected pass of TestBSDArchives on Windows

Originally failing due to https://github.com/llvm/llvm-project/issues/24901,
but since https://github.com/llvm/llvm-project/pull/110837 the
test is passing.

https://lab.llvm.org/buildbot/#/builders/141/builds/3012

My guess is that the `llvm-` tool has better support for static
libraries on Windows.

Added: 
    

Modified: 
    lldb/test/API/functionalities/archives/TestBSDArchives.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/archives/TestBSDArchives.py b/lldb/test/API/functionalities/archives/TestBSDArchives.py
index 928e9508617ad6..eb79b7ff47ebc7 100644
--- a/lldb/test/API/functionalities/archives/TestBSDArchives.py
+++ b/lldb/test/API/functionalities/archives/TestBSDArchives.py
@@ -21,10 +21,6 @@ def setUp(self):
         # Find the line number in a(int) to break at.
         self.line = line_number("a.c", "// Set file and line breakpoint inside a().")
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24527.  Makefile.rules doesn't know how to build static libs on Windows",
-    )
     def test(self):
         """Break inside a() and b() defined within libfoo.a."""
         self.build()


        


More information about the lldb-commits mailing list