[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

[via lldb-commits]

================
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
   return 0;
 }
 
+struct SaveCoreRequest {
+  SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {}
+
+  ~SaveCoreRequest() {
+    if (!m_success)
+      m_builder.DeleteFile();
----------------
jeffreytan81 wrote:

We should emit visible error message telling end user that saving minidump has failed instead of silently fail and remove minidump file.

https://github.com/llvm/llvm-project/pull/108259