[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 12 10:34:39 PDT 2024


================
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
   return 0;
 }
 
+struct SaveCoreRequest {
----------------
jeffreytan81 wrote:

Per our naming convention, let's call this RAII class `FileRemoveHolder/DumpFailRemoveHolder` or something similar, then the reader immediately know it is a RAII class. The current `SaveCoreRequest` is not indicating its purpose.

https://github.com/llvm/llvm-project/pull/108259


More information about the lldb-commits mailing list