[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

[David Spickett via lldb-commits]

================
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
 
 NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
     const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-    : NativeRegisterContextWindows(native_thread,
-                                   CreateRegisterInfoInterface(target_arch)) {}
+    : NativeRegisterContextRegisterInfo(
+          native_thread, CreateRegisterInfoInterface(target_arch)) {
+  // Currently, there is no API to query the maximum supported hardware
+  // breakpoints and watchpoints on Windows. The values set below are based
----------------
DavidSpickett wrote:

Ok so the kernel structure is always there it just isn't going to write the values to hardware (or it does and the hardware ignores it, but same result either way).

It's a shame because this means an lldb-server built on WoA CpuX won't detect more or less points on CpuY (I think Jason already said this).

I also wouldn't say we need to use Pavel's idea right now. Another option would be to do it based on CPU ID if we have access to that in Windows.

https://github.com/llvm/llvm-project/pull/108072