[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

[Omair Javaid via lldb-commits]

================
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
 
 NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
     const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-    : NativeRegisterContextWindows(native_thread,
-                                   CreateRegisterInfoInterface(target_arch)) {}
+    : NativeRegisterContextRegisterInfo(
+          native_thread, CreateRegisterInfoInterface(target_arch)) {
+  // Currently, there is no API to query the maximum supported hardware
+  // breakpoints and watchpoints on Windows. The values set below are based
----------------
omjavaid wrote:

Also winnt.h defines wvr, wcr, bvr and bcr arrays which has size equal to ARM64_MAX_WATCHPOINTS or ARM64_MAX_BREAKPOINTS. So we should be able to read and write those arrays regardless of whether they eventually generate a watchpoint or breakpoint exception or not.

https://github.com/llvm/llvm-project/pull/108072