[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

via lldb-commits lldb-commits at lists.llvm.org
Sun Aug 25 14:49:34 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 675c748bb606d75a959481e6014299849cf3094c...32786ae0abb7c465dfab602b1d53da11dd1dc7a7 lldb/test/API/lang/cpp/std-invoke-recognizer/TestStdInvokeRecognizer.py lldb/test/API/lang/cpp/std-function-recognizer/TestStdFunctionRecognizer.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- std-function-recognizer/TestStdFunctionRecognizer.py	2024-08-25 21:07:43.000000 +0000
+++ std-function-recognizer/TestStdFunctionRecognizer.py	2024-08-25 21:49:08.462694 +0000
@@ -15,14 +15,19 @@
             self, "// break here", lldb.SBFileSpec("main.cpp")
         )
         self.assertIn("foo", thread.GetFrameAtIndex(0).GetFunctionName())
         # Skip all hidden frames
         frame_id = 1
-        while frame_id < thread.GetNumFrames() and thread.GetFrameAtIndex(frame_id).IsHidden():
+        while (
+            frame_id < thread.GetNumFrames()
+            and thread.GetFrameAtIndex(frame_id).IsHidden()
+        ):
             frame_id = frame_id + 1
         # Expect `std::function<...>::operator()` to be the direct parent of `foo`
-        self.assertIn("::operator()", thread.GetFrameAtIndex(frame_id).GetFunctionName())
+        self.assertIn(
+            "::operator()", thread.GetFrameAtIndex(frame_id).GetFunctionName()
+        )
         # And right above that, there should be the `main` frame
         self.assertIn("main", thread.GetFrameAtIndex(frame_id + 1).GetFunctionName())
 
     @add_test_categories(["libc++"])
     def test_backtrace(self):
--- std-invoke-recognizer/TestStdInvokeRecognizer.py	2024-08-25 21:07:43.000000 +0000
+++ std-invoke-recognizer/TestStdInvokeRecognizer.py	2024-08-25 21:49:08.482565 +0000
@@ -14,18 +14,30 @@
         (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
             self, "// break here", lldb.SBFileSpec("main.cpp")
         )
 
         while process.GetState() != lldb.eStateExited:
-            self.assertTrue(any(f in thread.GetFrameAtIndex(0).GetFunctionName() for f in ["print_num", "add", "PrintAdder"]))
+            self.assertTrue(
+                any(
+                    f in thread.GetFrameAtIndex(0).GetFunctionName()
+                    for f in ["print_num", "add", "PrintAdder"]
+                )
+            )
             print(thread.GetFrameAtIndex(0).GetFunctionName())
             # Skip all hidden frames
             frame_id = 1
-            while frame_id < thread.GetNumFrames() and thread.GetFrameAtIndex(frame_id).IsHidden():
+            while (
+                frame_id < thread.GetNumFrames()
+                and thread.GetFrameAtIndex(frame_id).IsHidden()
+            ):
                 print(thread.GetFrameAtIndex(frame_id).GetFunctionName())
                 frame_id = frame_id + 1
             print(thread.GetFrameAtIndex(frame_id).GetFunctionName())
             # Expect `std::invoke` to be the direct parent
-            self.assertIn("::invoke", thread.GetFrameAtIndex(frame_id).GetFunctionName())
+            self.assertIn(
+                "::invoke", thread.GetFrameAtIndex(frame_id).GetFunctionName()
+            )
             # And right above that, there should be the `main` frame
-            self.assertIn("main", thread.GetFrameAtIndex(frame_id + 1).GetFunctionName())
+            self.assertIn(
+                "main", thread.GetFrameAtIndex(frame_id + 1).GetFunctionName()
+            )
             process.Continue()

``````````

</details>


https://github.com/llvm/llvm-project/pull/105695


More information about the lldb-commits mailing list