[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 22 10:53:03 PDT 2024


================
@@ -101,6 +103,18 @@ bool SaveCoreOptions::ShouldThreadBeSaved(lldb::tid_t tid) const {
   return m_threads_to_save.count(tid) > 0;
 }
 
+bool SaveCoreOptions::HasSpecifiedThreads() const {
+  return !m_threads_to_save.empty();
+}
+
+void SaveCoreOptions::AddMemoryRegionToSave(const lldb_private::MemoryRegionInfo &region) {
+  m_regions_to_save.Insert(region.GetRange(), /*combine=*/true);
----------------
clayborg wrote:

Does this keep things sorted and merge ranges? Or do we post process these ranges somewhere? At some point we will need to iterate over the ranges to save and break them up according to permissions.

https://github.com/llvm/llvm-project/pull/105442


More information about the lldb-commits mailing list