[Lldb-commits] [lldb] [lldb-dap] Enabling instruction breakpoint support to lldb-dap. (PR #105278)

[Santhosh Kumar Ellendula via lldb-commits]

================
@@ -4078,6 +4255,9 @@ void RegisterRequestCallbacks() {
   g_dap.RegisterRequestCallback("threads", request_threads);
   g_dap.RegisterRequestCallback("variables", request_variables);
   g_dap.RegisterRequestCallback("disassemble", request_disassemble);
+  // Instruction breapoint request
----------------
santhoshe447 wrote:

@vogelsgesang 
Thanks for bringing this point.
The GDB remote protocol does not have a specific packet for instruction breakpoints, which is likely why LLDB manages instruction breakpoints using the z0 packet, just like it does for software breakpoints.
The challenge is distinguishing between instruction breakpoints and software breakpoints when they use the same packet type.

**Instruction breakpoints packet info:**
$[{"name":"mandelbrot","reason":"breakpoint","registers":{"16":"3046555555550000","6":"10e3ffffff7f0000","7":"00e3ffffff7f0000"}],"signal":5,"tid":12342}]]#72

**Source breakpoint packet info:**
$[{"name":"mandelbrot","reason":"breakpoint","registers":{"16":"2e46555555550000","6":"10e3ffffff7f0000","7":"00e3ffffff7f0000"}],"signal":5,"tid":12342}]]#a6

It would be helpful if you could share any insights on this.


https://github.com/llvm/llvm-project/pull/105278