[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

[via lldb-commits]

jeffreytan81 wrote:

@walter-erquinigo, the performance issue is not only showing for 1% rare gigantic target. It is actually reported by a customer's target with 4000 modules with only 3GB of debug info. Disabling this feature significantly improves the stepping experience. 
To get a sense of the scale, in our company, there are 1/3 targets with debug info > 10GB, and 1/3 targets between 1-10GB, and remaining 1/3 below 1GB. 3GB debug info target is simply a below average target while it is already showing very noticeable stepping slowness for end users. Also, I do not think 1 second stepping performance regression is an acceptable engineering trade off overtime.

Note: the profile trace I shared above comes from profiling a hello world target and I have seen similar hot path for lldb-dap running on Mac, but I do not have time to measure Mac's impact. 






https://github.com/llvm/llvm-project/pull/104874