[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 21 10:39:03 PDT 2024


================
@@ -90,6 +93,16 @@ bool SBSaveCoreOptions::RemoveThread(lldb::SBThread thread) {
   return m_opaque_up->RemoveThread(thread.GetSP());
 }
 
+
+lldb::SBError SBSaveCoreOptions::AddMemoryRegionToSave(const SBMemoryRegionInfo &region) {
+  LLDB_INSTRUMENT_VA(this, region);
+  // Currently add memory region can't fail, so we always return a success 
+  // SBerror, but because these API's live forever, this is the most future
+  // proof thing to do.
----------------
bulbazord wrote:

Thanks for being forward-looking. 😄 

https://github.com/llvm/llvm-project/pull/105442


More information about the lldb-commits mailing list