[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

[John Harrison via lldb-commits]

================
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object &request) {
     // This will always return an invalid thread when
     // libBacktraceRecording.dylib is not loaded or if there is no extended
     // backtrace.
-    lldb::SBThread queue_backtrace_thread =
-        thread.GetExtendedBacktraceThread("libdispatch");
+    lldb::SBThread queue_backtrace_thread;
+    if (g_dap.enable_display_extended_backtrace)
+      queue_backtrace_thread = thread.GetExtendedBacktraceThread("libdispatch");
----------------
ashgti wrote:

Maybe we should check SBProcess::GetNumExtendedBacktraceTypes() / GetExtendedBacktraceTypeAtIndex() instead of hard coding the `libdispatch`? I think that is configured by the target platform.

Would that solve the issue without needing an extra configuration flag?

https://github.com/llvm/llvm-project/pull/104874