[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> The code format test passed but, I see some new failures (mostly in lldb-api and some in lldb-shell), which were not there in the previous run.

Not sure if you mean in the GitHub CI or locally, but either way I doubt they are due to your change. I'll see what the current CI run does.

> Could it be because my branch is not up to date?

Well, it could in fact be because your branch *is* up to date :) LLVM is a "live at head" sort of model where the main branch can be all kinds of broken depending on when you pull it. We fix these issues pretty fast but you can still be unlucky.

The advice is not to rebase the PR if you can avoid it: https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes

But for example if you post a PR and the very first CI run has failures, it would be fine to rebase it before any significant review has taken place. Just to make it clear the issues are not your fault. Or if the comments were all addressed, etc, you'll get a feel for it over time.

> How can I avoid such failures for future PRs?

Don't rebase unless you have to. If when you land the PR things fail because some later change interacts with yours, that's fine that's what the post commit Buildbots are intended to catch.

The other side effect of llvm being "live at head" is that reverts are very common, so if they happen don't be discouraged, it happens to everyone. I wrote this up in more verbose terms in https://llvm.org/docs/MyFirstTypoFix.html#issues-after-landing-your-pr.

https://github.com/llvm/llvm-project/pull/104679