[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

Paul Kirth via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 19 07:48:48 PDT 2024


ilovepi wrote:

I think the need to add _GNU_SOURCE depends on your libc, it it’s probably reasonable to add it based on the platform. 

I’d think you’d want to use an ifdef here to define _GNU_SOURCE if needed. I based on the target platform.  You could also probably do something similar in CMAKE but you may want to limit that in scope to only this test, since I’m not completely sure of the impact, though IIRC it’s safe. 

Regardless, I’d appreciate it if this was reverted until a fixed version ready, since is been breaking our CI since it landed. 

https://github.com/llvm/llvm-project/pull/104109


More information about the lldb-commits mailing list