[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)
Dmitry Vasilyev via lldb-commits
lldb-commits at lists.llvm.org
Fri Aug 16 06:25:25 PDT 2024
slydiman wrote:
@labath
> Basically, the code should look similar to [this](https://github.com/llvm/llvm-project/blob/f71b63865140cf3c286baf3a77ba3e467f929504/lldb/source/Host/common/TCPSocket.cpp#L267), except that it will be listening to two unrelated sockets.
> Reasoning about a singlethreaded application is much easier than for a multithreaded one. We should already have all of the pieces to do this the right way, so let's just do that.
So, the TCPSocket class supports a list of listening native sockets. But Acceptor does not support them. MainLoop is not accessible anywhere. I'm going to remove the new thread for accepting gdb connections and refactor Acceptor to listen on 2 ports in the same main thread instead.
https://github.com/llvm/llvm-project/pull/104238
More information about the lldb-commits
mailing list