[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

[David Spickett via lldb-commits]

================
@@ -147,15 +147,8 @@ GDB-SERVER CONNECTIONS
 
 .. option:: --gdbserver-port <port>
 
- Define a port to be used for gdb-server connections. Can be specified multiple
- times to allow multiple ports. Has no effect if --min-gdbserver-port
- and --max-gdbserver-port are specified.
-
-.. option:: --min-gdbserver-port <port>
-.. option:: --max-gdbserver-port <port>
-
- Specify the range of ports that can be used for gdb-server connections. Both
- options need to be specified simultaneously. Overrides --gdbserver-port.
+ Define a port to be used for gdb-server connections. This port is used for
+ multiple connections.
----------------
DavidSpickett wrote:

Thanks, I understood that bit.

What I was missing was basic socket theory, that on the remote side we can look at the IP address of the sender so IP A to port N can be differentiated from IP B sending to port N. It's been a very long time since I had to think about this, but in hindsight, of course lots of things multiplex this way.

Nothing wrong with the code, if anything it was a bit too magical :) And a good improvement for the way I use lldb in my work.

https://github.com/llvm/llvm-project/pull/104238