[Lldb-commits] [lldb] [lldb] Fully namespace SBType callback function parameters (PR #102375)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Chelsea Cassanova (chelcassanova)

<details>
<summary>Changes</summary>

This commit fully namespaces callback function pointer parameters that are SB types in `SBDefines` and `lldb-types`.

---
Full diff: https://github.com/llvm/llvm-project/pull/102375.diff


2 Files Affected:

- (modified) lldb/include/lldb/API/SBDefines.h (+5-5) 
- (modified) lldb/include/lldb/lldb-types.h (+1-1) 


``````````diff
diff --git a/lldb/include/lldb/API/SBDefines.h b/lldb/include/lldb/API/SBDefines.h
index f42e2be558d2e7..9543ebc08a320f 100644
--- a/lldb/include/lldb/API/SBDefines.h
+++ b/lldb/include/lldb/API/SBDefines.h
@@ -135,16 +135,16 @@ class LLDB_API SBWatchpoint;
 class LLDB_API SBWatchpointOptions;
 class LLDB_API SBUnixSignals;
 
-typedef bool (*SBBreakpointHitCallback)(void *baton, SBProcess &process,
-                                        SBThread &thread,
+typedef bool (*SBBreakpointHitCallback)(void *baton, lldb::SBProcess &process,
+                                        lldb::SBThread &thread,
                                         lldb::SBBreakpointLocation &location);
 
 typedef void (*SBDebuggerDestroyCallback)(lldb::user_id_t debugger_id,
                                           void *baton);
 
-typedef SBError (*SBPlatformLocateModuleCallback)(
-    void *baton, const SBModuleSpec &module_spec, SBFileSpec &module_file_spec,
-    SBFileSpec &symbol_file_spec);
+typedef lldb::SBError (*SBPlatformLocateModuleCallback)(
+    void *baton, const lldb::SBModuleSpec &module_spec,
+    lldb::SBFileSpec &module_file_spec, lldb::SBFileSpec &symbol_file_spec);
 }
 
 #endif // LLDB_API_SBDEFINES_H
diff --git a/lldb/include/lldb/lldb-types.h b/lldb/include/lldb/lldb-types.h
index d88b8232ee6b4d..15781ad626efbd 100644
--- a/lldb/include/lldb/lldb-types.h
+++ b/lldb/include/lldb/lldb-types.h
@@ -72,7 +72,7 @@ typedef int pipe_t;                     // Host pipe type
 
 typedef void (*LogOutputCallback)(const char *, void *baton);
 typedef bool (*CommandOverrideCallback)(void *baton, const char **argv);
-typedef bool (*ExpressionCancelCallback)(ExpressionEvaluationPhase phase,
+typedef bool (*ExpressionCancelCallback)(lldb::ExpressionEvaluationPhase phase,
                                          void *baton);
 
 typedef void *ScriptObjectPtr;

``````````

</details>


https://github.com/llvm/llvm-project/pull/102375