[Lldb-commits] [lldb] [lldb] Fully namespace SBType callback function parameters (PR #102375)

Chelsea Cassanova via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 7 14:41:24 PDT 2024


https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/102375

This commit fully namespaces callback function pointer parameters that are SB types in `SBDefines` and `lldb-types`.

>From 6525ca91f6ef49b06613ec6e947f54d3faf73efe Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova <chelsea_cassanova at apple.com>
Date: Wed, 7 Aug 2024 14:36:10 -0700
Subject: [PATCH] [lldb] Fully namespace SBType callback function parameters

This commit fully namespaces callback function pointer parameters that are SB
types in `SBDefines` and `lldb-types`.
---
 lldb/include/lldb/API/SBDefines.h | 10 +++++-----
 lldb/include/lldb/lldb-types.h    |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lldb/include/lldb/API/SBDefines.h b/lldb/include/lldb/API/SBDefines.h
index f42e2be558d2e..9543ebc08a320 100644
--- a/lldb/include/lldb/API/SBDefines.h
+++ b/lldb/include/lldb/API/SBDefines.h
@@ -135,16 +135,16 @@ class LLDB_API SBWatchpoint;
 class LLDB_API SBWatchpointOptions;
 class LLDB_API SBUnixSignals;
 
-typedef bool (*SBBreakpointHitCallback)(void *baton, SBProcess &process,
-                                        SBThread &thread,
+typedef bool (*SBBreakpointHitCallback)(void *baton, lldb::SBProcess &process,
+                                        lldb::SBThread &thread,
                                         lldb::SBBreakpointLocation &location);
 
 typedef void (*SBDebuggerDestroyCallback)(lldb::user_id_t debugger_id,
                                           void *baton);
 
-typedef SBError (*SBPlatformLocateModuleCallback)(
-    void *baton, const SBModuleSpec &module_spec, SBFileSpec &module_file_spec,
-    SBFileSpec &symbol_file_spec);
+typedef lldb::SBError (*SBPlatformLocateModuleCallback)(
+    void *baton, const lldb::SBModuleSpec &module_spec,
+    lldb::SBFileSpec &module_file_spec, lldb::SBFileSpec &symbol_file_spec);
 }
 
 #endif // LLDB_API_SBDEFINES_H
diff --git a/lldb/include/lldb/lldb-types.h b/lldb/include/lldb/lldb-types.h
index d88b8232ee6b4..15781ad626efb 100644
--- a/lldb/include/lldb/lldb-types.h
+++ b/lldb/include/lldb/lldb-types.h
@@ -72,7 +72,7 @@ typedef int pipe_t;                     // Host pipe type
 
 typedef void (*LogOutputCallback)(const char *, void *baton);
 typedef bool (*CommandOverrideCallback)(void *baton, const char **argv);
-typedef bool (*ExpressionCancelCallback)(ExpressionEvaluationPhase phase,
+typedef bool (*ExpressionCancelCallback)(lldb::ExpressionEvaluationPhase phase,
                                          void *baton);
 
 typedef void *ScriptObjectPtr;



More information about the lldb-commits mailing list