[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

Vladislav Dzhidzhoev via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 31 09:53:44 PDT 2024


================
@@ -138,7 +191,7 @@ def use_support_substitutions(config):
     # Set up substitutions for support tools.  These tools can be overridden at the CMake
     # level (by specifying -DLLDB_LIT_TOOLS_DIR), installed, or as a last resort, we can use
     # the just-built version.
-    host_flags = ["--target=" + config.host_triple]
+    host_flags = ["--target=" + config.target_triple]
----------------
dzhidzhoev wrote:

Hmm. I thought it was named after the substitution name %clang_host (used by tests not bound to the specific architecture).
I think it may be better to rename the substitution to %clang_target instead, but it requires a huge change of all tests.
Otherwise, we get the line like 
`config.substitutions.append(("%clang_host", "%clang " + target_flags))`
which also looks confusing IMO.

https://github.com/llvm/llvm-project/pull/95986


More information about the lldb-commits mailing list