[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 31 01:10:58 PDT 2024


================
@@ -138,7 +191,7 @@ def use_support_substitutions(config):
     # Set up substitutions for support tools.  These tools can be overridden at the CMake
     # level (by specifying -DLLDB_LIT_TOOLS_DIR), installed, or as a last resort, we can use
     # the just-built version.
-    host_flags = ["--target=" + config.host_triple]
+    host_flags = ["--target=" + config.target_triple]
----------------
DavidSpickett wrote:

Is it worth changing this variable name?

Naming is hard, but "host" sounds like the thing hosting the test runner, where now it refers to the thing that the tests run on. `target_flags` maybe?

https://github.com/llvm/llvm-project/pull/95986


More information about the lldb-commits mailing list