[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 24 20:44:43 PDT 2024


================
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const {
   return m_file;
 }
 
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+  Status error;
+  if (!process_sp) {
+    ClearProcessSpecificData();
+    m_process_sp = std::nullopt;
----------------
clayborg wrote:

Don't use optionals for std::shared_ptr as it being NULL is enough. This then becomes:
```
m_process_sp.reset();
```

https://github.com/llvm/llvm-project/pull/100443


More information about the lldb-commits mailing list